[feat] Add IPv6 public backends for NodeBalancers#545
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 73.43% 73.62% +0.19%
==========================================
Files 19 19
Lines 2906 2927 +21
==========================================
+ Hits 2134 2155 +21
Misses 523 523
Partials 249 249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move the post-generation CAPL manifest patching into a dedicated hack script so the Makefile stays readable while still injecting the eth1 IPv6 source-routing bootstrap and CCM image overrides into generated manifests. The routing bootstrap installs a small systemd-backed script on control-plane and worker nodes to pin replies sourced from the public eth1 IPv6 back out through eth1. This avoids the dual-NIC ECMP reply-path issue that was causing public IPv6 backend traffic to leak to eth0 and flap NodeBalancer health. Also fix the lb-with-node-addition e2e to discover the actual worker MachineDeployment by cluster label instead of assuming capl-cluster-md-0, and wait for ready replicas instead of sleeping blindly. That makes the test match current CAPL naming and removes the deterministic MachineDeployment not found failure.
Run lb-with-node-addition in its own CI step and dedicated Make target, using a Chainsaw label selector instead of the general all test batch. This keeps the cluster-scaling test from mutating node membership while other load-balancer tests are running in parallel. Also widen the wait windows that were too short for CI: allow up to 10 minutes of 30-second polling for the new MachineDeployment replica to become ready, and extend the IPv6 load balancer readiness gate so backend programming and LB health checks have more time to settle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior
--enable-ipv6-for-nodebalancer-backendsas a global controller flagservice.beta.kubernetes.io/linode-loadbalancer-enable-ipv6-backendsas a per-service overrideCode Changes
cloud/annotations/annotations.gocloud/linode/options/options.goand register the flag inmain.gocloud/linode/loadbalancers.goto:deploy/chart/templates/daemonset.yamlanddeploy/chart/values.yamldocs/configuration/loadbalancer.md,docs/configuration/environment.md, anddocs/configuration/annotations.md.gitignoreTests
Unit
cloud/linode/loadbalancers_test.gowith coverage for:E2E
e2e/test/lb-with-ipv6-backends/LoadBalancerservice annotated withlinode-loadbalancer-enable-ipv6-backends: "true"Verification
go test ./cloud/linode/...make test